-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Broadcom Devices in amd-smi framework #71
Open
mcharles-brcm
wants to merge
11
commits into
ROCm:amd-staging
Choose a base branch
from
mcharles-brcm:amd-staging
base: amd-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. As part of this we have added Broadcom's NIC and SWITCH devices in the amd-smi framework. 2. The affected command is 'amd-smi list' 3. Filter the NIC and SWITCH devices based on the Broadcom's vendor ids 4. Since these changes are depending on sysfs entries which is created by broadcom drivers, if no brcm driver present in the system then necessary elements will not created as part of the list command.
NIC/Switch LIST
List Nic/Switch
mcharles-brcm
requested review from
marifamd,
bill-shuzhou-liu,
dmitrii-galantsev,
charis-poag-amd and
oliveiradan
as code owners
January 26, 2025 08:29
As part of this feature, 1. Added monitor attributes for BRCM devices - NIC and SWITCH 2. The affected amd-smi command is 'amd-smi monitor' 3. The list of monitor attributes are read from the corresponding BRCM device's sysfs path
BRCM Monitor
BRCM Monitor
rahulc1984
pushed a commit
that referenced
this pull request
Jan 30, 2025
Fix ordering of RHEL 8 build process Signed-off-by: Williams, Justin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this feature,
Updated (1/27)
i) NIC_TEMP_CURRENT
ii) NIC_TEMP_CRIT_ALARM
iii) NIC_TEMP_EMERGENCY_ALARM
iv) NIC_TEMP_SHUTDOWN_ALARM
v) NIC_TEMP_MAX_ALARM
i) CURRENT_LINK_SPEED
ii) MAX_LINK_SPEED
iii) CURRENT_LINK_WIDTH
iv) MAX_LINK_WIDTH